| Summary: | [Mac] Return multiple ranges for seekable from MediaPlayerPrivateAVFoundation. | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||||||
| Status: | NEW --- | ||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, glenn, philipj, rniwa, sergio | ||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Jer Noble
2015-01-07 10:01:00 PST
Created attachment 244159 [details]
Patch
Comment on attachment 244159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:890 > + [m_avPlayer setRate:requestedRate()]; > + Oops! Comment on attachment 244159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review I think this looks good. r=me. > Source/WebCore/ChangeLog:9 > + the number of iterations over that array (of one item) in half. Cool! > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-401 > - return MediaTime::zeroTime(); Do we not need to handle the case where metadata isn't available anymore? I guess the m_cachedSeekableTimeRanges is nullptr in this case, so we just return an empty PlatformTimeRanges object? Comment on attachment 244159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244159&action=review >> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-401 >> - return MediaTime::zeroTime(); > > Do we not need to handle the case where metadata isn't available anymore? I guess the m_cachedSeekableTimeRanges is nullptr in this case, so we just return an empty PlatformTimeRanges object? Yep, that's the idea. >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:890 >> + > > Oops! Oops indeed! Part of another patch. Created attachment 244162 [details]
Patch for landing
Comment on attachment 244159 [details] Patch Attachment 244159 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5172514837757952 Number of test failures exceeded the failure limit. Created attachment 244164 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 244159 [details] Patch Attachment 244159 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6518873268420608 Number of test failures exceeded the failure limit. Created attachment 244166 [details]
Archive of layout-test-results from ews100 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 244162 [details] Patch for landing Attachment 244162 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4884825580240896 Number of test failures exceeded the failure limit. Created attachment 244168 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 244162 [details] Patch for landing Attachment 244162 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5379656815476736 Number of test failures exceeded the failure limit. Created attachment 244169 [details]
Archive of layout-test-results from ews101 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 244183 [details]
Patch for landing
Comment on attachment 244183 [details] Patch for landing Attachment 244183 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5184468134395904 Number of test failures exceeded the failure limit. Created attachment 244187 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 244183 [details] Patch for landing Attachment 244183 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5491794519261184 Number of test failures exceeded the failure limit. Created attachment 244198 [details]
Archive of layout-test-results from ews102 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 244294 [details]
Patch for landing
Comment on attachment 244294 [details] Patch for landing Rejecting attachment 244294 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 244294, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4797709147963392 |