Bug 140170

Summary:

Make webkit-patch try harder to find keychain credentials

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dbates, glenn, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description Myles C. Maxfield 2015-01-06 20:22:51 PST

Make webkit-patch try harder to find keychain credentials

Comment 1 Myles C. Maxfield 2015-01-06 20:26:21 PST

Created attachment 244133 [details]
Patch

Comment 2 Ryosuke Niwa 2015-01-06 22:05:36 PST

Comment on attachment 244133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244133&action=review

> Tools/Scripts/webkitpy/common/net/credentials.py:121
> +            if parsed_output[0] or parsed_output[1]:

Why not any(parsed_output)?

Comment 3 Myles C. Maxfield 2015-01-07 13:20:58 PST

Committed r178049: <http://trac.webkit.org/changeset/178049>