Bug 140142

Summary: Only throttle DOM timers if they change CSS properties that cannot cause non-descendant elements to become visible
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, dbates, kling, koivisto, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2015-01-06 13:02:42 PST 
Only throttle DOM timers if they change CSS properties that cannot cause non-descendant elements to become visible. For example, a DOM timer may change the height of an element that is outside the viewport. However, changing its height may causes elements inside the viewport to move. As such, we should NOT throttle such DOM timer.
Comment 1 Chris Dumez 2015-01-06 13:49:40 PST 
Created attachment 244093 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-06 18:08:24 PST 
Comment on attachment 244093 [details]
Patch

Clearing flags on attachment: 244093

Committed r178014: <http://trac.webkit.org/changeset/178014>
Comment 3 WebKit Commit Bot 2015-01-06 18:08:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Daniel Bates 2015-01-13 16:45:49 PST 
Comment on attachment 244093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244093&action=review

> LayoutTests/fast/dom/timer-height-change-no-throttling.html:31
> +    setTimeout(scrollElementIntoView, 0);

Did you mean to include this line? If so, scrollElementIntoView needs to be defined.
Comment 5 Chris Dumez 2015-01-13 16:46:46 PST 
Comment on attachment 244093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244093&action=review

>> LayoutTests/fast/dom/timer-height-change-no-throttling.html:31
>> +    setTimeout(scrollElementIntoView, 0);
> 
> Did you mean to include this line? If so, scrollElementIntoView needs to be defined.

No, this line needs to go away.
Comment 6 Chris Dumez 2015-01-13 16:48:35 PST 
Reopening to attach new patch.
Comment 7 Chris Dumez 2015-01-13 16:48:38 PST 
Created attachment 244563 [details]
Patch
Comment 8 WebKit Commit Bot 2015-01-13 19:35:47 PST 
Comment on attachment 244563 [details]
Patch

Clearing flags on attachment: 244563

Committed r178403: <http://trac.webkit.org/changeset/178403>
Comment 9 WebKit Commit Bot 2015-01-13 19:35:53 PST 
All reviewed patches have been landed.  Closing bug.