Bug 140112

Summary: Move '-webkit-scroll-snap-*' CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2015-01-05 20:19:28 PST 
Move '-webkit-scroll-snap-*' CSS properties to the new StyleBuilder
Comment 1 Chris Dumez 2015-01-05 21:05:29 PST 
Created attachment 244031 [details]
Patch
Comment 2 Darin Adler 2015-01-06 01:44:27 PST 
Comment on attachment 244031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244031&action=review

> Source/WebCore/css/StyleBuilderConverter.h:109
> +#endif // ENABLE(CSS_SCROLL_SNAP)

This comment isn’t helpful. The #if is only one line away!
Comment 3 Chris Dumez 2015-01-06 08:09:24 PST 
Created attachment 244062 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-06 08:50:04 PST 
Comment on attachment 244062 [details]
Patch

Clearing flags on attachment: 244062

Committed r177958: <http://trac.webkit.org/changeset/177958>
Comment 5 WebKit Commit Bot 2015-01-06 08:50:08 PST 
All reviewed patches have been landed.  Closing bug.