Bug 140099

Summary: Purge PassRefPtr from SharedBuffer.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mountainlion
none
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 none

Andreas Kling
Reported 2015-01-05 14:38:34 PST
Purge PassRefPtr from SharedBuffer.
Attachments
Patch (37.50 KB, patch)
2015-01-05 17:24 PST, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mountainlion (574.52 KB, application/zip)
2015-01-05 17:53 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (513.48 KB, application/zip)
2015-01-05 17:59 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-01-05 17:24:18 PST
Created attachment 244020 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-05 17:26:43 PST
Attachment 244020 [details] did not pass style-queue: ERROR: Source/WebCore/platform/SharedBuffer.h:61: The parameter name "vector" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/SharedBuffer.h:67: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2015-01-05 17:53:22 PST
Comment on attachment 244020 [details] Patch Attachment 244020 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6200193540161536 New failing tests: http/tests/appcache/offline-access.html
Build Bot
Comment 4 2015-01-05 17:53:24 PST
Created attachment 244024 [details] Archive of layout-test-results from ews103 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 5 2015-01-05 17:59:31 PST
Comment on attachment 244020 [details] Patch Attachment 244020 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6550374706053120 New failing tests: http/tests/appcache/offline-access.html
Build Bot
Comment 6 2015-01-05 17:59:33 PST
Created attachment 244025 [details] Archive of layout-test-results from ews105 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Ahmad Saleem
Comment 7 2022-09-17 17:03:06 PDT
PassRefPtr usage does not exist anymore in Webkit GitHub as of today. So I am marking this as "RESOLVED WONTFIX". Thanks!
Note You need to log in before you can comment on or make changes to this bug.