Bug 140076

Summary: Web Inspector: inspector view top inset should not include height of web view banners
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Incorrect top inset
none
Patch
none
Patch none

Matt Baker
Reported 2015-01-04 22:37:31 PST
Created attachment 243965 [details] Incorrect top inset When docked on the right, the top inset of the Inspector frame offset should not include the heights of any banners installed in the inspected web view. This causes a gap at the top of the Inspector view. Steps to reproduce: 1) Dock inspector on the right. 2) Bring up the "Find in page" search bar in the inspected page. 3) Force inspector view to resize (drag splitter bar). 4) The inspector view moves below the search bar.
Attachments
Incorrect top inset (420.54 KB, image/png)
2015-01-04 22:37 PST, Matt Baker
no flags
Patch (4.21 KB, patch)
2015-01-05 01:00 PST, Matt Baker
no flags
Patch (4.25 KB, patch)
2015-01-05 15:15 PST, Matt Baker
no flags
Radar WebKit Bug Importer
Comment 1 2015-01-04 22:37:44 PST
Matt Baker
Comment 2 2015-01-05 01:00:28 PST
Joseph Pecoraro
Comment 3 2015-01-05 15:00:43 PST
Comment on attachment 243969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243969&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:4159 > +- (void)_setTotalHeightOfBanners:(CGFloat)totalHeightOfBanners > +{ > + _data->_totalHeightOfBanners = totalHeightOfBanners; > +} > + > - (CGFloat)_topContentInset > { > return _data->_topContentInset; > } > > +- (CGFloat)_totalHeightOfBanners > +{ > + return _data->_totalHeightOfBanners; > +} The order of these methods is weird. You should put the equivalent getters/setters side by side. So in this case -_setTotalHeightOfBanners: next to -_totalHeightOfBanners.
Matt Baker
Comment 4 2015-01-05 15:15:53 PST
Joseph Pecoraro
Comment 5 2015-01-05 16:45:35 PST
Comment on attachment 244010 [details] Patch Looks good to me. Needs a WebKit2 Owner approval I think.
WebKit Commit Bot
Comment 6 2015-01-05 18:13:49 PST
Comment on attachment 244010 [details] Patch Clearing flags on attachment: 244010 Committed r177944: <http://trac.webkit.org/changeset/177944>
WebKit Commit Bot
Comment 7 2015-01-05 18:13:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.