Created attachment 243965 [details] Incorrect top inset When docked on the right, the top inset of the Inspector frame offset should not include the heights of any banners installed in the inspected web view. This causes a gap at the top of the Inspector view. Steps to reproduce: 1) Dock inspector on the right. 2) Bring up the "Find in page" search bar in the inspected page. 3) Force inspector view to resize (drag splitter bar). 4) The inspector view moves below the search bar.
<rdar://problem/19371800>
Created attachment 243969 [details] Patch
Comment on attachment 243969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243969&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:4159 > +- (void)_setTotalHeightOfBanners:(CGFloat)totalHeightOfBanners > +{ > + _data->_totalHeightOfBanners = totalHeightOfBanners; > +} > + > - (CGFloat)_topContentInset > { > return _data->_topContentInset; > } > > +- (CGFloat)_totalHeightOfBanners > +{ > + return _data->_totalHeightOfBanners; > +} The order of these methods is weird. You should put the equivalent getters/setters side by side. So in this case -_setTotalHeightOfBanners: next to -_totalHeightOfBanners.
Created attachment 244010 [details] Patch
Comment on attachment 244010 [details] Patch Looks good to me. Needs a WebKit2 Owner approval I think.
Comment on attachment 244010 [details] Patch Clearing flags on attachment: 244010 Committed r177944: <http://trac.webkit.org/changeset/177944>
All reviewed patches have been landed. Closing bug.