Bug 140049

Summary: [EFL][WK2] EFL MiniBrowser doesn't run because shared library is not found
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ljaehun.lim, lucas.de.marchi, ossy, p.forysiuk, sanxiyn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200074
Attachments:
Description Flags
Patch none

Description Gyuyoung Kim 2015-01-02 22:33:53 PST
EFL MiniBrowser can't be executed until we set DependenciesEFL/Root/lib to LD_LIBRARY_PATH. I guess this problem happened when we changed "Dependencies" directory to "DependenciesEFL" directory.

WebKitBuild/Release/bin/MiniBrowser: error while loading shared libraries: libecore_input.so.1: cannot open shared object file: No such file or directory
Comment 1 Jaehun Lim 2015-01-02 23:18:02 PST
This is because elementary doesn't find other EFL libraries after jhbuild.
I think we need to set rpath when jhbuild builds elementary.
Comment 2 Paweł Forysiuk 2015-01-14 02:53:22 PST
I cannot reproduce this with the current checkout.
Comment 3 Gyuyoung Kim 2015-01-14 19:55:29 PST
(In reply to comment #2)
> I cannot reproduce this with the current checkout.

I have still this problem. Didn't you set anything in your environment ?
Comment 4 Csaba Osztrogonác 2015-01-14 22:31:21 PST
It works with Tools/Scriptrs/run-launcher --efl
Comment 5 Paweł Forysiuk 2015-01-14 23:41:31 PST
(In reply to comment #3)
> I have still this problem. Didn't you set anything in your environment?

No I did not set up anything myself just had clean WebKitBuild folder.
Just to note I use Ubuntu 14.04 but I doubt it matters here.
Comment 6 Jaehun Lim 2015-01-14 23:47:20 PST
(In reply to comment #5)
> (In reply to comment #3)
> > I have still this problem. Didn't you set anything in your environment?
> 
> No I did not set up anything myself just had clean WebKitBuild folder.
> Just to note I use Ubuntu 14.04 but I doubt it matters here.

Do you install efl and elementary on your system ?
If you did, MiniBrowser runs with your system efl or elementary.

Please check with ldd.
Comment 7 Paweł Forysiuk 2015-01-15 00:13:34 PST
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > I have still this problem. Didn't you set anything in your environment?
> > 
> > No I did not set up anything myself just had clean WebKitBuild folder.
> > Just to note I use Ubuntu 14.04 but I doubt it matters here.
> 
> Do you install efl and elementary on your system ?
> If you did, MiniBrowser runs with your system efl or elementary.
> 
> Please check with ldd.

I'm gonna burn in shame now :(. Yes I had efl installed some time ago for something unrelated and forgot. 
I looked at ldd but somehow overlooked the so path before. Sorry again.
I will try to investigate this a bit more.
Comment 8 Paweł Forysiuk 2015-01-20 07:06:57 PST
Looks like this was introduced in r176442

"[CMake] Use ld.gold if it is available to speedup builds"
​https://bugs.webkit.org/show_bug.cgi?id=137953

After reverting this commit and rebuilding sources Minibrowser launches properly.
Comment 9 Csaba Osztrogonác 2015-01-20 07:11:06 PST
Maybe bug139126 fixes the issue. Could you check it?
Comment 10 Paweł Forysiuk 2015-01-20 07:45:07 PST
(In reply to comment #9)
> Maybe bug139126 fixes the issue. Could you check it?

Yes. I can confirm that applying that patch fixes the issue on my machine.
Comment 11 Csaba Osztrogonác 2015-01-20 07:51:23 PST
Created attachment 244993 [details]
Patch
Comment 12 Csaba Osztrogonác 2015-01-20 07:51:52 PST
*** Bug 139126 has been marked as a duplicate of this bug. ***
Comment 13 Jaehun Lim 2015-01-20 16:41:34 PST
(In reply to comment #10)
> (In reply to comment #9)
> > Maybe bug139126 fixes the issue. Could you check it?
> 
> Yes. I can confirm that applying that patch fixes the issue on my machine.

It works for me. Thanks.
Comment 14 Gyuyoung Kim 2015-01-21 01:32:35 PST
Comment on attachment 244993 [details]
Patch

rs=me
Comment 15 WebKit Commit Bot 2015-01-21 02:20:51 PST
Comment on attachment 244993 [details]
Patch

Clearing flags on attachment: 244993

Committed r178823: <http://trac.webkit.org/changeset/178823>
Comment 16 WebKit Commit Bot 2015-01-21 02:20:57 PST
All reviewed patches have been landed.  Closing bug.