Bug 140030

Summary: ASSERT that a null key is never used with FeatureCounter
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2015-01-01 13:29:30 PST 
ASSERT that a null key is never used with FeatureCounter
Comment 1 Chris Dumez 2015-01-01 13:31:34 PST 
Created attachment 243869 [details]
Patch
Comment 2 Chris Dumez 2015-01-01 14:09:10 PST 
Created attachment 243871 [details]
Patch
Comment 3 Darin Adler 2015-01-01 15:07:01 PST 
Comment on attachment 243871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243871&action=review

> Source/WebCore/platform/FeatureCounter.cpp:55
> +    ASSERT_ARG(key, key);

Release builds will give a warning unless you use ASSERT_UNUSED here.

> Source/WebCore/platform/FeatureCounter.cpp:61
> +    ASSERT_ARG(key, key);

Release builds will give a warning unless you use ASSERT_UNUSED here.
Comment 4 Chris Dumez 2015-01-01 15:12:00 PST 
Created attachment 243873 [details]
Patch
Comment 5 WebKit Commit Bot 2015-01-01 15:53:20 PST 
Comment on attachment 243873 [details]
Patch

Clearing flags on attachment: 243873

Committed r177851: <http://trac.webkit.org/changeset/177851>
Comment 6 WebKit Commit Bot 2015-01-01 15:53:25 PST 
All reviewed patches have been landed.  Closing bug.