| Summary: | Remove the remaining uses of OwnPtr from WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, jamesr, luiz, mitz, ossy, tonikitoo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2014-12-31 10:28:07 PST
Created attachment 243850 [details]
Patch
Committed r177835: <http://trac.webkit.org/changeset/177835> (In reply to comment #2) > Committed r177835: <http://trac.webkit.org/changeset/177835> It broke the EFL build, as the EWS noticed it before landing and the buildbots noticed after landing: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In constructor ‘WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics(WebCore::Page*)’: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:49:28: error: ‘create’ is not a member of ‘WebCore::ScrollingStateTree’ , m_scrollingStateTree(ScrollingStateTree::create()) ^ ninja: build stopped: subcommand failed. buildfix landed in https://trac.webkit.org/changeset/177840 Just out of curiosity: Is there a new policy about Apple is allowed to break other builds intentionally outside WebKit2 in the new year? I probably missed the announce about it on webkit-dev ... (In reply to comment #5) > Just out of curiosity: Is there a new policy about Apple is allowed > to break other builds intentionally outside WebKit2 in the new year? > > I probably missed the announce about it on webkit-dev ... Nope. I just didn't botice I broke it. Ping me next time and I will fix it right away. |