Bug 139974

Summary: Don’t use AccessibilityAllInOne when building with Xcode
Product: WebKit Reporter: mitz
Component: WebCore Misc.Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Stop using AccessibilityAllInOne.cpp darin: review+

mitz
Reported 2014-12-28 09:35:37 PST
Use of AccessibilityAllInOne in Xcode builds was introduced in <http://trac.webkit.org/r77878> to address bug 53681, an issue with 32-builds on Leopard. That’s no longer a supported configuration, so the all-in-one workaround shouldn’t be necessary anymore.
Attachments
Stop using AccessibilityAllInOne.cpp (11.74 KB, patch)
2014-12-28 09:37 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-12-28 09:37:10 PST
Created attachment 243782 [details] Stop using AccessibilityAllInOne.cpp
mitz
Comment 2 2014-12-28 09:38:53 PST
(The downside of using AccessibilityAllInOne.cpp is that any change in any file included by any of the 23 .cpp files it includes requires all 23 files to be recompiled).
Darin Adler
Comment 3 2014-12-28 11:11:03 PST
Comment on attachment 243782 [details] Stop using AccessibilityAllInOne.cpp OK. Why?
Darin Adler
Comment 4 2014-12-28 11:11:19 PST
Oh, I see why.
mitz
Comment 5 2014-12-28 11:29:27 PST
Committed <http://trac.webkit.org/r177781>.
mitz
Comment 6 2014-12-28 13:01:09 PST
(In reply to comment #5) > Committed <http://trac.webkit.org/r177781>. I reverted this change in <http://trac.webkit.org/r177784>, because it seems to have caused something like bug 139609 on iOS. I am going to attempt this again once the iOS issue is understood.
mitz
Comment 7 2014-12-28 13:03:57 PST
(In reply to comment #6) > (In reply to comment #5) > > Committed <http://trac.webkit.org/r177781>. > > I reverted this change in <http://trac.webkit.org/r177784>, because it seems > to have caused something like bug 139609 on iOS. The issue on iOS turned out to be a configuration issue that is different from bug 139609.
mitz
Comment 8 2014-12-31 11:03:33 PST
Committed <http://trac.webkit.org/r177834>.
Note You need to log in before you can comment on or make changes to this bug.