Bug 139965

Summary: Implement encoding and decoding of ObjCObjectGraph objects
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+

Anders Carlsson
Reported 2014-12-27 10:20:25 PST
Implement encoding and decoding of ObjCObjectGraph objects
Attachments
Patch (9.37 KB, patch)
2014-12-27 10:22 PST, Anders Carlsson 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-12-27 10:22:57 PST
Created attachment 243776 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-27 10:25:34 PST
Attachment 243776 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:268: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:268: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2014-12-27 12:29:37 PST
It was already landed in https://trac.webkit.org/changeset/177765. Can we close the bug?
Anders Carlsson
Comment 4 2014-12-27 12:32:33 PST
Yup, not sure why webkit-patch didn't close it.
Note You need to log in before you can comment on or make changes to this bug.