Bug 139965 - Implement encoding and decoding of ObjCObjectGraph objects
Summary: Implement encoding and decoding of ObjCObjectGraph objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-27 10:20 PST by Anders Carlsson
Modified: 2014-12-27 12:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.37 KB, patch)
2014-12-27 10:22 PST, Anders Carlsson 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-12-27 10:20:25 PST 
Implement encoding and decoding of ObjCObjectGraph objects
Comment 1 Anders Carlsson 2014-12-27 10:22:57 PST 
Created attachment 243776 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-27 10:25:34 PST 
Attachment 243776 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:172:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:268:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/ObjCObjectGraph.mm:268:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2014-12-27 12:29:37 PST 
It was already landed in https://trac.webkit.org/changeset/177765. Can we close the bug?
Comment 4 Anders Carlsson 2014-12-27 12:32:33 PST 
Yup, not sure why webkit-patch didn't close it.