Bug 139963

Summary: Disable W3C test harness timeout
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2014-12-26 19:51:12 PST
W3C test harness has "normal" and "long" timeouts, and tests can choose which to use. But there is no way to make these conditional on build style, and the built-in values are inappropriate for some debug builds, such as leaks bots or ASan/GuardMalloc. Perhaps we can simply disable the built-in timeouts, and let run-webkit-tests/DumpRenderTree/WebKitTestRunner work normally.
Attachments
proposed patch (2.23 KB, patch)
2014-12-26 19:53 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-12-26 19:53:21 PST
Created attachment 243772 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-12-27 14:33:39 PST
Comment on attachment 243772 [details] proposed patch Clearing flags on attachment: 243772 Committed r177770: <http://trac.webkit.org/changeset/177770>
WebKit Commit Bot
Comment 3 2014-12-27 14:33:42 PST
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 4 2014-12-27 19:25:58 PST
This seems to have caused media failures. See https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r177770%20(1158)/results.html
Alexey Proskuryakov
Comment 5 2014-12-28 00:25:53 PST
Ugh. Perhaps some tests had failure expectations, and time out now? build.webkit.org fails to load at the moment.
Alexey Proskuryakov
Comment 6 2014-12-28 10:51:58 PST
Two tests had error output with line numbers, and line numbers changed. Updated in r177780.
Note You need to log in before you can comment on or make changes to this bug.