Bug 139948

Summary: Fix build warning after r177700
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit2Assignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, gyuyoung.kim, gyuyoung.kim, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hunseop Jeong
Reported 2014-12-25 17:29:27 PST
../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53:21: warning: unused parameter ‘object’ [-Wunused-parameter] RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) ^ ../../Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:60:21: warning: unused parameter ‘object’ [-Wunused-parameter] RefPtr<API::Object> WebConnectionToWebProcess::transformObjectsToHandles(API::Object* object)
Attachments
Patch (1.55 KB, patch)
2014-12-25 17:32 PST, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2014-12-25 17:35 PST, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.67 KB, patch)
2014-12-25 18:15 PST, Hunseop Jeong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hunseop Jeong
Comment 1 2014-12-25 17:32:34 PST
Created attachment 243751 [details] Patch
Hunseop Jeong
Comment 2 2014-12-25 17:35:35 PST
Created attachment 243752 [details] Patch
Gyuyoung Kim
Comment 3 2014-12-25 18:01:13 PST
Comment on attachment 243752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243752&action=review > Source/WebKit2/ChangeLog:3 > + Unreviewed, fix build warning after r177700 Build warning should be reviewed. And also it would be good to get a review from WK2 owner. > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53 > RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) In this case, I would recommend to remove object parameter here instead of UNUSED_PARAM(). > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63 > + UNUSED_PARAM(object); ditto.
Hunseop Jeong
Comment 4 2014-12-25 18:13:11 PST
(In reply to comment #3) > Comment on attachment 243752 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243752&action=review > > > Source/WebKit2/ChangeLog:3 > > + Unreviewed, fix build warning after r177700 > > Build warning should be reviewed. And also it would be good to get a review > from WK2 owner. > Okay, I try to get a review from WK2 owner. > > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:53 > > RefPtr<API::Object> WebConnectionToWebProcess::transformHandlesToObjects(API::Object* object) > > In this case, I would recommend to remove object parameter here instead of > UNUSED_PARAM(). > > > Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:63 > > + UNUSED_PARAM(object); > > ditto. I removed the parameter instead of UNUSED_PARAM(). Thanks,
Hunseop Jeong
Comment 5 2014-12-25 18:15:50 PST
Created attachment 243753 [details] Patch
WebKit Commit Bot
Comment 6 2014-12-25 19:52:00 PST
Comment on attachment 243753 [details] Patch Clearing flags on attachment: 243753 Committed r177743: <http://trac.webkit.org/changeset/177743>
WebKit Commit Bot
Comment 7 2014-12-25 19:52:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.