Bug 139940

Summary:

[Cocoa] Some modern SPI changes have missing or incorrect availability annotations

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Update availability annotations, add WK_DEPRECATED for the modern API	darin: review+

Description mitz 2014-12-24 21:26:03 PST

Some recent changes to private headers in the modern API had missing or incorrect availability annotations.

Comment 1 mitz 2014-12-24 21:40:20 PST

Created attachment 243736 [details]
Update availability annotations, add WK_DEPRECATED for the modern API

Comment 2 Darin Adler 2014-12-24 22:24:33 PST

Comment on attachment 243736 [details]
Update availability annotations, add WK_DEPRECATED for the modern API

View in context: https://bugs.webkit.org/attachment.cgi?id=243736&action=review

> Source/WebKit2/ChangeLog:11
> +        to mean that the declaration is currently depracated. When API availability is enabled.

Typo: deprecated

Not sure I understand that last sentence fragment.

Comment 3 mitz 2014-12-24 22:30:12 PST

(In reply to comment #2)
> Comment on attachment 243736 [details]
> Update availability annotations, add WK_DEPRECATED for the modern API
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243736&action=review
> 
> > Source/WebKit2/ChangeLog:11
> > +        to mean that the declaration is currently depracated. When API availability is enabled.
> 
> Typo: deprecated
> 
> Not sure I understand that last sentence fragment.

I left that in by mistake!

Comment 4 mitz 2014-12-26 11:19:05 PST

Fixed in <http://trac.webkit.org/r177747>.