Bug 139940

Summary: [Cocoa] Some modern SPI changes have missing or incorrect availability annotations
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update availability annotations, add WK_DEPRECATED for the modern API darin: review+

mitz
Reported 2014-12-24 21:26:03 PST
Some recent changes to private headers in the modern API had missing or incorrect availability annotations.
Attachments
Update availability annotations, add WK_DEPRECATED for the modern API (36.51 KB, patch)
2014-12-24 21:40 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-12-24 21:40:20 PST
Created attachment 243736 [details] Update availability annotations, add WK_DEPRECATED for the modern API
Darin Adler
Comment 2 2014-12-24 22:24:33 PST
Comment on attachment 243736 [details] Update availability annotations, add WK_DEPRECATED for the modern API View in context: https://bugs.webkit.org/attachment.cgi?id=243736&action=review > Source/WebKit2/ChangeLog:11 > + to mean that the declaration is currently depracated. When API availability is enabled. Typo: deprecated Not sure I understand that last sentence fragment.
mitz
Comment 3 2014-12-24 22:30:12 PST
(In reply to comment #2) > Comment on attachment 243736 [details] > Update availability annotations, add WK_DEPRECATED for the modern API > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243736&action=review > > > Source/WebKit2/ChangeLog:11 > > + to mean that the declaration is currently depracated. When API availability is enabled. > > Typo: deprecated > > Not sure I understand that last sentence fragment. I left that in by mistake!
mitz
Comment 4 2014-12-26 11:19:05 PST
Fixed in <http://trac.webkit.org/r177747>.
Note You need to log in before you can comment on or make changes to this bug.