Bug 139938 – Use std::unique_ptr<> in WebCore/dom, plugin, and graphics

• Component: New Bugs
• Status: RESOLVED FIXED

[Gyuyoung Kim]

SSIA.

[Gyuyoung Kim]

Created attachment 243731 [details]
Patch

[Build Bot]

Comment on attachment 243731 [details]
Patch

Attachment 243731 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5121866435919872

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 243732 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 243731 [details]
Patch

Attachment 243731 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5746546880544768

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 243733 [details]
Archive of layout-test-results from ews104 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Perhaps the crashes are caused by the bot not recompiling all the necessary files?

r=me assuming we get to the bottom of the crashes.

[Darin Adler]

Comment on attachment 243731 [details]
Patch

Change looks fine to me, but I am really worried about the test failures on the buildbots. Please find some way to check into that before landing.

[Gyuyoung Kim]

Created attachment 243743 [details]
Patch for landing

[Gyuyoung Kim]

(In reply to comment #7)
> Comment on attachment 243731 [details]
> Patch
> 
> Change looks fine to me, but I am really worried about the test failures on
> the buildbots. Please find some way to check into that before landing.

Test failures on ews seem to occur because #include <OwnPtr.h> were removed some files.

[WebKit Commit Bot]

Comment on attachment 243743 [details]
Patch for landing

Clearing flags on attachment: 243743

Committed r177737: <http://trac.webkit.org/changeset/177737>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Myles C. Maxfield]

(In reply to comment #9)
> (In reply to comment #7)
> > Comment on attachment 243731 [details]
> > Patch
> > 
> > Change looks fine to me, but I am really worried about the test failures on
> > the buildbots. Please find some way to check into that before landing.
> 
> Test failures on ews seem to occur because #include <OwnPtr.h> were removed
> some files.

And this didn't cause compile failures?

Did this change cause the errors seen here? <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84186>

[Gyuyoung Kim]

(In reply to comment #13)
> Did this change cause the errors seen here?
> <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84186>


It seems to me that win debug build has been broken since r177729. I'm not fully sure if my commit caused the break.

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84177

[Gyuyoung Kim]

(In reply to comment #12)
> (In reply to comment #9)
> > (In reply to comment #7)
> > > Comment on attachment 243731 [details]
> > > Patch
> > > 
> > > Change looks fine to me, but I am really worried about the test failures on
> > > the buildbots. Please find some way to check into that before landing.
> > 
> > Test failures on ews seem to occur because #include <OwnPtr.h> were removed
> > some files.
> 
> And this didn't cause compile failures?

yes, it looks be weird. I will remove the OwnPtr.h soon. Let me check it again then.

(In reply to comment #14)
> (In reply to comment #13)
> > Did this change cause the errors seen here?
> > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > 84186>
> 
> 
> It seems to me that win debug build has been broken since r177729. I'm not
> fully sure if my commit caused the break.
> 
> https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84177

The errors in build 84186 specifically appear to be related to this change.

[Gyuyoung Kim]

(In reply to comment #16)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > Did this change cause the errors seen here?
> > > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > 84186>
> > 
> > 
> > It seems to me that win debug build has been broken since r177729. I'm not
> > fully sure if my commit caused the break.
> > 
> > https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > 84177
> 
> The errors in build 84186 specifically appear to be related to this change.

Oh, I see. let me check it.

[Gyuyoung Kim]

(In reply to comment #17)
> (In reply to comment #16)
> > (In reply to comment #14)
> > > (In reply to comment #13)
> > > > Did this change cause the errors seen here?
> > > > <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > > 84186>
> > > 
> > > 
> > > It seems to me that win debug build has been broken since r177729. I'm not
> > > fully sure if my commit caused the break.
> > > 
> > > https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> > > 84177
> > 
> > The errors in build 84186 specifically appear to be related to this change.
> 
> Oh, I see. let me check it.

I revert codes related to NoEventDispatchAssertion for win debug build, because it is hard to check this break on win bot for me now. Anyway it looks fine now. Let me check it in next time again.

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/84188

(In reply to comment #18)

> I revert codes related to NoEventDispatchAssertion for win debug build,
> because it is hard to check this break on win bot for me now. Anyway it
> looks fine now. Let me check it in next time again.
> 
> https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/
> 84188

Thank you for fixing the build!