Bug 139892

Summary: Use ctiPatchCallByReturnAddress() in JITOperations.cpp
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2014-12-22 18:05:58 PST
The code in JITOperations.cpp is sometimes calling RepatchBuffer::relinkCallerToFunction() directly, and sometimes using a helper function, ctiPatchCallByReturnAddress(). This patch changes it to use the helper function consistently.
Attachments
the patch. (3.57 KB, patch)
2014-12-22 18:10 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-12-22 18:10:42 PST
Created attachment 243656 [details] the patch. The perf numbers shows that perf is a neutral with this patch.
Michael Saboff
Comment 2 2014-12-22 18:13:28 PST
Comment on attachment 243656 [details] the patch. r=me
WebKit Commit Bot
Comment 3 2014-12-22 18:48:10 PST
Comment on attachment 243656 [details] the patch. Clearing flags on attachment: 243656 Committed r177675: <http://trac.webkit.org/changeset/177675>
WebKit Commit Bot
Comment 4 2014-12-22 18:48:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.