Bug 139861

Summary: [MSE] Implement Append Window support.
Product: WebKit Reporter: Bartlomiej Gajda <b.gajda>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
implement appendwindow v1
none
implement appendwindow v1+layouttest none

Bartlomiej Gajda
Reported 2014-12-22 06:26:29 PST
There is no support for SourceBuffer.appendWindowStart and SourceBuffer.appendWindowEnd yet.
Attachments
implement appendwindow v1 (8.59 KB, patch)
2014-12-22 06:30 PST, Bartlomiej Gajda 		no flags
DetailsFormatted DiffDiff
implement appendwindow v1+layouttest (14.60 KB, patch)
2015-01-09 06:29 PST, Bartlomiej Gajda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bartlomiej Gajda
Comment 1 2014-12-22 06:30:11 PST
Created attachment 243622 [details] implement appendwindow v1 Added appendWindowStart, appendWindowEnd and missing logic; also reordered idl to match order from spec.
Jer Noble
Comment 2 2015-01-05 10:19:27 PST
Comment on attachment 243622 [details] implement appendwindow v1 The patch looks good, but it needs a layout test.
Bartlomiej Gajda
Comment 3 2015-01-09 06:29:15 PST
Created attachment 244339 [details] implement appendwindow v1+layouttest added LayoutTest which adds same range 3 times with different appendWindows and checks for buffered.
Jer Noble
Comment 4 2015-01-09 08:36:13 PST
Comment on attachment 244339 [details] implement appendwindow v1+layouttest Nice!
WebKit Commit Bot
Comment 5 2015-01-09 09:16:16 PST
Comment on attachment 244339 [details] implement appendwindow v1+layouttest Clearing flags on attachment: 244339 Committed r178172: <http://trac.webkit.org/changeset/178172>
WebKit Commit Bot
Comment 6 2015-01-09 09:16:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.