Bug 139857

Summary: Allow the WebContext's history client to coexist with WKWebView's history delegate
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2014-12-21 13:41:25 PST 
Allow the WebContext's history client to coexist with WKWebView's history delegate
Comment 1 Sam Weinig 2014-12-21 13:46:39 PST 
Created attachment 243615 [details]
Patch
Comment 2 Anders Carlsson 2014-12-22 09:02:09 PST 
Comment on attachment 243615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243615&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3081
> +    // Notify the loader client.

I don't think this comment is useful.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3084
> +    // Also, notify the legacy history client on the WebContext.

Same here (and all the other comments that say the same thing!)
Comment 3 Sam Weinig 2014-12-22 11:04:47 PST 
Committed r177636: <http://trac.webkit.org/changeset/177636>