Bug 139799

Summary: [Win] Update DumpRenderTree to more closely match Mac version
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 139972    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Brent Fulgham
Reported 2014-12-18 16:34:30 PST
Reorder the contents of the Windows implementation of DumpRenderTree so that it is easier to compare the steps taken when starting and ending our layout tests. Also implement a handful of functions so that Windows does a better job of handling its caches and other local storage.
Attachments
Patch (49.75 KB, patch)
2014-12-18 16:44 PST, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-12-18 16:44:28 PST
Created attachment 243533 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-18 16:46:27 PST
Attachment 243533 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/DumpRenderTree.cpp:56: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit/win/WebSecurityOrigin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-12-18 16:46:34 PST
Comment on attachment 243533 [details] Patch rs=me
Brent Fulgham
Comment 4 2014-12-18 17:00:26 PST
Committed r177542: <http://trac.webkit.org/changeset/177542>
Note You need to log in before you can comment on or make changes to this bug.