| Summary: | Change page preview loading order, and add a TextIndicator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, conrad_shultz, eric.carlson, glenn, jer.noble, philipj, sam, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-12-18 14:01:43 PST
Created attachment 243518 [details]
Patch
Attachment 243518 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/spi/mac/NSPopoverSPI.h:41: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKPreviewPopoverAnimationController.mm:325: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243518&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:244 > + Unnecessary whitespace? |