Bug 139773

Summary: [EFL][WK2] Minibrowser : Add search icon to search bar
Product: WebKit Reporter: Tanay <tanay.c>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tanay 2014-12-18 05:26:12 PST
Add decoration icon in the search field in the minibrowser.
Comment 1 Tanay 2014-12-18 05:28:34 PST
Created attachment 243494 [details]
Patch
Comment 2 Tanay 2015-01-13 01:24:02 PST
(In reply to comment #1)
> Created attachment 243494 [details]
> Patch

Hi all, request to review.
Comment 3 Csaba Osztrogonác 2015-02-19 03:29:48 PST
I tested, it works fine for me.

It seems a little bit strange for me that search_icon is handled 
in a different way as other parts of the search toolbar, but I'm
not EFL UI expert, so I let the technical review for others.
Comment 4 Tanay 2015-03-03 21:44:22 PST
Hi , It is implemented such that it supports changes to search icon as per the theme. Also to reuse the existing icon. Please let me know if there are any other comments?
Comment 5 Ryuan Choi 2015-03-03 21:51:07 PST
Comment on attachment 243494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243494&action=review

> Tools/MiniBrowser/efl/main.c:417
> +    edje_obj = edje_object_add(window->elm_window);
> +    edje_object_file_set(edje_obj, DEFAULT_THEME_DIR "/default.edj", "webkit/widget/search/results_decoration");
> +    icon = edje_object_part_object_get(edje_obj, "decoration");

Are there any reason you want to use edje object of webkit theme instead of standard elm_icon such as "edit-find" ?
Comment 6 Tanay 2015-03-04 04:19:10 PST
I cannot find a icon suitable for this purpose in the already existing elm_icon's. Since the suitable icon is only available in webkit theme i am re-using the same.
Comment 7 Ryuan Choi 2015-03-05 18:20:21 PST
(In reply to comment #6)
> I cannot find a icon suitable for this purpose in the already existing
> elm_icon's. Since the suitable icon is only available in webkit theme i am
> re-using the same.

Please check "edit-find". It is introduced since 1.13.

I think that we can use it because ewebkit is under development on EFL 1.13 since r180697.
Comment 8 Tanay 2015-05-14 23:15:02 PDT
Created attachment 253178 [details]
Patch
Comment 9 Tanay 2015-05-14 23:17:26 PDT
Sorry for the delay. I am uploading a patch using the "edit-find" icon available in EFL 1.13. Please have a look.
Comment 10 Gyuyoung Kim 2015-05-15 23:23:46 PDT
Comment on attachment 253178 [details]
Patch

LGTM. r=me.
Comment 11 WebKit Commit Bot 2015-05-16 00:12:31 PDT
Comment on attachment 253178 [details]
Patch

Clearing flags on attachment: 253178

Committed r184432: <http://trac.webkit.org/changeset/184432>
Comment 12 WebKit Commit Bot 2015-05-16 00:12:40 PDT
All reviewed patches have been landed.  Closing bug.