Bug 139771

Summary: [GTK] [EFL] Enable per_test_timeout
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cgarcia, commit-queue, glenn, gyuyoung.kim, mrobinson, ossy, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2014-12-18 05:06:55 PST 
Following the discussion on https://bugs.webkit.org/show_bug.cgi?id=139671 and https://bugs.webkit.org/show_bug.cgi?id=139734

supports_per_test_timeout() should be enabled in order to pass to WKTR the --timeout parameter:

Tools/Scripts/webkitpy/port/driver.py:        if self._port.supports_per_test_timeout():
Tools/Scripts/webkitpy/port/driver.py:            command += "'--timeout'%s" % driver_input.timeout


This is needed to make WKTR use either the default port timeout, or the user supplied timeout via "Tools/Scripts/run-webkit-tests --time-out-ms=...". Otherwise WTR will use the default (30 seconds after r177363).


GTK and EFL ports are not enabling it, so enable it.
Comment 1 Carlos Alberto Lopez Perez 2014-12-18 05:27:59 PST 
Created attachment 243493 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-12-18 05:29:44 PST 
Comment on attachment 243493 [details]
Patch

rs=me
Comment 3 Carlos Alberto Lopez Perez 2014-12-18 05:32:44 PST 
Comment on attachment 243493 [details]
Patch

Clearing flags on attachment: 243493

Committed r177493: <http://trac.webkit.org/changeset/177493>
Comment 4 Carlos Alberto Lopez Perez 2014-12-18 05:32:52 PST 
All reviewed patches have been landed.  Closing bug.