Bug 139748

Summary: [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, ddkilzer, glenn, jake.nielsen.webkit, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Simon Fraser (smfr)
Reported 2014-12-17 14:17:42 PST
[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
Attachments
Patch (5.21 KB, patch)
2014-12-17 14:19 PST, Simon Fraser (smfr) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-12-17 14:19:19 PST
Created attachment 243461 [details] Patch
Daniel Bates
Comment 2 2014-12-17 14:23:42 PST
Comment on attachment 243461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243461&action=review > Tools/Scripts/webkitpy/port/factory.py:47 > + optparse.make_option('--ios-simulator', action='store_const', dest='platform', This will break the Apple Internal iOS test bots. Please coordinate with Jake Nielsen.
Simon Fraser (smfr)
Comment 3 2014-12-17 17:59:44 PST
Actually the bots can migrate to using --ios-simulator right now; that works.
David Kilzer (:ddkilzer)
Comment 4 2015-01-18 16:16:00 PST
There was one patch landed for this bug as a staging change to allow time to update internal buildbots: Committed r177510: <http://trac.webkit.org/changeset/177510>
David Kilzer (:ddkilzer)
Comment 5 2015-01-24 08:24:25 PST
(In reply to comment #4) > There was one patch landed for this bug as a staging change to allow time to > update internal buildbots: > > Committed r177510: <http://trac.webkit.org/changeset/177510> Internal buildbots have been updated to use --ios-simulator. Clear to land this patch now.
Daniel Bates
Comment 6 2015-01-26 20:06:42 PST
Committed r179162: <http://trac.webkit.org/changeset/179162>
Note You need to log in before you can comment on or make changes to this bug.