| Summary: | [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, commit-queue, dbates, ddkilzer, glenn, jake.nielsen.webkit, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-12-17 14:17:42 PST
Created attachment 243461 [details]
Patch
Comment on attachment 243461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243461&action=review > Tools/Scripts/webkitpy/port/factory.py:47 > + optparse.make_option('--ios-simulator', action='store_const', dest='platform', This will break the Apple Internal iOS test bots. Please coordinate with Jake Nielsen. Actually the bots can migrate to using --ios-simulator right now; that works. There was one patch landed for this bug as a staging change to allow time to update internal buildbots: Committed r177510: <http://trac.webkit.org/changeset/177510> (In reply to comment #4) > There was one patch landed for this bug as a staging change to allow time to > update internal buildbots: > > Committed r177510: <http://trac.webkit.org/changeset/177510> Internal buildbots have been updated to use --ios-simulator. Clear to land this patch now. Committed r179162: <http://trac.webkit.org/changeset/179162> |