Bug 139748 - [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
Summary: [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 14:17 PST by Simon Fraser (smfr)
Modified: 2015-01-26 20:06 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2014-12-17 14:19 PST, Simon Fraser (smfr) 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-12-17 14:17:42 PST 
[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
Comment 1 Simon Fraser (smfr) 2014-12-17 14:19:19 PST 
Created attachment 243461 [details]
Patch
Comment 2 Daniel Bates 2014-12-17 14:23:42 PST 
Comment on attachment 243461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243461&action=review

> Tools/Scripts/webkitpy/port/factory.py:47
> +        optparse.make_option('--ios-simulator', action='store_const', dest='platform',

This will break the Apple Internal iOS test bots. Please coordinate with Jake Nielsen.
Comment 3 Simon Fraser (smfr) 2014-12-17 17:59:44 PST 
Actually the bots can migrate to using --ios-simulator right now; that works.
Comment 4 David Kilzer (:ddkilzer) 2015-01-18 16:16:00 PST 
There was one patch landed for this bug as a staging change to allow time to update internal buildbots:

Committed r177510:  <http://trac.webkit.org/changeset/177510>
Comment 5 David Kilzer (:ddkilzer) 2015-01-24 08:24:25 PST 
(In reply to comment #4)
> There was one patch landed for this bug as a staging change to allow time to
> update internal buildbots:
> 
> Committed r177510:  <http://trac.webkit.org/changeset/177510>

Internal buildbots have been updated to use --ios-simulator.

Clear to land this patch now.
Comment 6 Daniel Bates 2015-01-26 20:06:42 PST 
Committed r179162: <http://trac.webkit.org/changeset/179162>