| Summary: | [iOS] Define button and action should respect profile settings. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
| Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | iOS 8.1 | ||||||
| Attachments: |
|
||||||
|
Description
Enrica Casucci
2014-12-17 12:11:28 PST
Created attachment 243449 [details]
Patch
Attachment 243449 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:51: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1342: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243449&action=review r=me > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:52 > +#import <ManagedConfiguration/MCProfileConnection.h> > +#import <ManagedConfiguration/MCFeatures.h> Nit: `sort` which you already noticed. Are these SPI? In order for this to build with the public SDK do you have to do something special? dbates has been doing something like that, so there may be something you have to do here, or maybe not. Committed revision 177463. |