Summary: | TestWebKitAPI should use a static lib to support both Mac and iOS cleanly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mitz | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2014-12-16 18:49:07 PST
Created attachment 243422 [details]
Patch
Comment on attachment 243422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243422&action=review > Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:30 > +// FIXME: This should not be built on iOS. Instead we should TestWebKitAPI.app. I think you're missing a word between "should" and "TestWebKitAPI.app". > Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:34 > + > +LD_RUNPATH_SEARCH_PATHS = "@loader_path/."; I don't see why this change would require that this be added if it wasn't already needed. > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:308 > + 7CCE7E8A1A41144E00447C4C /* CopyFiles */ = { > + isa = PBXCopyFilesBuildPhase; > + buildActionMask = 2147483647; > + dstPath = "include/$(PRODUCT_NAME)"; > + dstSubfolderSpec = 16; > + files = ( > + ); > + runOnlyForDeploymentPostprocessing = 0; > + }; This Copy Files phase doesn't seem necessary. Created attachment 243423 [details]
Patch
Comment on attachment 243423 [details]
Patch
One of my comments from the earlier patch still applies.
Was there any follow-up to this? Is the static library used for anything other than linking the TestWebKitAPI executable? I see that people have kept adding tests directly to that target. Does that mean that those tests don’t run in iOS? (In reply to comment #6) > Was there any follow-up to this? Is the static library used for anything > other than linking the TestWebKitAPI executable? I see that people have kept > adding tests directly to that target. Does that mean that those tests don’t > run in iOS? No follow up yet. The plan was to add a .app for iOS device. I need to check with Simon if that is still necessary. |