Bug 139711

Summary:

REGRESSION: Preview popovers obscure the link, look wrong

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2014-12-16 16:10:05 PST

Preview popovers are obscurring the link. This is a regression from adoping immediate actions.

rdar://problem/19271854

Comment 1 Beth Dakin 2014-12-16 16:14:13 PST

Created attachment 243403 [details]
Patch

Comment 2 Tim Horton 2014-12-16 16:15:22 PST

Comment on attachment 243403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243403&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:422
> +    NSPopoverAnimationController *popoverController = [NSPopoverAnimationController popoverAnimationControllerWithPopover:_previewPopover.get()];

Do you need a respondsToSelector here?

Comment 3 Beth Dakin 2014-12-16 16:33:48 PST

http://trac.webkit.org/changeset/177409 Thanks!