Bug 139705

Summary: Move Mac process suppression from WebCore to WebKit2
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ggaren: review+

Gavin Barraclough
Reported 2014-12-16 14:06:08 PST
Currently PageThrottler constructs the PageActivityState, holds a copy of the ViewState, and an optional UserActivity. Instead, still construct the PageActivityState but just pass this out via the Page to WebPage. Logic From PageThrottler::updateUserActivity merged into WebPage::updateUserActivity.
Attachments
Fix (15.99 KB, patch)
2014-12-16 14:16 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-12-16 14:16:34 PST
Created attachment 243393 [details] Fix
Geoffrey Garen
Comment 2 2014-12-16 14:21:25 PST
Comment on attachment 243393 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=243393&action=review r=me > Source/WebCore/page/Page.h:294 > + void setPageActivityState(PageActivityState::Flags); Seems like this should just be named "setActivityState" and "ActivityState".
Gavin Barraclough
Comment 3 2014-12-16 14:30:54 PST
PageThrottler needs a new name too (since it no longer throttles!), will rename in a follow up. Transmitting file data ............ Committed revision 177396.
Note You need to log in before you can comment on or make changes to this bug.