Bug 139699

Summary:

Add a progress indicator to the preview popover

Product:

WebKit

Reporter:

Conrad Shultz <conrad_shultz>

Component:

WebKit2

Assignee:

Conrad Shultz <conrad_shultz>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, conrad_shultz, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Conrad Shultz 2014-12-16 13:15:28 PST

Add a progress indicator to the preview popover.

Comment 1 Conrad Shultz 2014-12-16 13:16:05 PST

<rdar://problem/19266297>

Comment 2 Conrad Shultz 2014-12-16 13:18:01 PST

Created attachment 243383 [details]
Patch

Comment 3 Tim Horton 2014-12-16 13:22:55 PST

Comment on attachment 243383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243383&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:135
> +- (void)_setPreviewLoading:(BOOL)loading;

I somewhat wish these had more specific names, but at this point you're just following the past.

Comment 4 Conrad Shultz 2014-12-16 15:15:02 PST

Committed: http://trac.webkit.org/changeset/177402