Bug 139697

Summary: Log which ActiveDOMObject(s) can't be suspended for PageCache.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2014-12-16 13:07:46 PST
When we're trying to put a page into PageCache, we should log which kinds of ActiveDOMObjects failed to suspend, causing us to opt out of PageCache.
Attachments
Patch (22.47 KB, patch)
2014-12-16 13:09 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (23.25 KB, patch)
2015-01-09 13:03 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-12-16 13:09:56 PST
Created attachment 243381 [details] Patch
Chris Dumez
Comment 2 2014-12-16 13:47:52 PST
Comment on attachment 243381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243381&action=review doesn't build? > Source/WebCore/dom/ScriptExecutionContext.cpp:199 > + unsuspendableObjects->append(activeDOMObject); else break;
Andreas Kling
Comment 3 2015-01-09 13:03:15 PST
Created attachment 244366 [details] Patch
Chris Dumez
Comment 4 2015-01-09 15:44:24 PST
Comment on attachment 244366 [details] Patch r=me
WebKit Commit Bot
Comment 5 2015-01-09 16:43:54 PST
Comment on attachment 244366 [details] Patch Clearing flags on attachment: 244366 Committed r178223: <http://trac.webkit.org/changeset/178223>
WebKit Commit Bot
Comment 6 2015-01-09 16:43:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.