Bug 139697

Summary: Log which ActiveDOMObject(s) can't be suspended for PageCache.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andreas Kling 2014-12-16 13:07:46 PST 
When we're trying to put a page into PageCache, we should log which kinds of ActiveDOMObjects failed to suspend, causing us to opt out of PageCache.
Comment 1 Andreas Kling 2014-12-16 13:09:56 PST 
Created attachment 243381 [details]
Patch
Comment 2 Chris Dumez 2014-12-16 13:47:52 PST 
Comment on attachment 243381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243381&action=review

doesn't build?

> Source/WebCore/dom/ScriptExecutionContext.cpp:199
> +                unsuspendableObjects->append(activeDOMObject);

else
  break;
Comment 3 Andreas Kling 2015-01-09 13:03:15 PST 
Created attachment 244366 [details]
Patch
Comment 4 Chris Dumez 2015-01-09 15:44:24 PST 
Comment on attachment 244366 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-01-09 16:43:54 PST 
Comment on attachment 244366 [details]
Patch

Clearing flags on attachment: 244366

Committed r178223: <http://trac.webkit.org/changeset/178223>
Comment 6 WebKit Commit Bot 2015-01-09 16:43:59 PST 
All reviewed patches have been landed.  Closing bug.