Bug 139693

Summary: Get rid of PassRefPtr inside StorageManager
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2014-12-16 12:26:09 PST
Get rid of PassRefPtr inside StorageManager
Comment 1 Anders Carlsson 2014-12-16 12:27:08 PST
Created attachment 243376 [details]
Patch
Comment 2 Andreas Kling 2014-12-16 12:33:23 PST
Comment on attachment 243376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243376&action=review

r=me but

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:49
> +    static RefPtr<StorageArea> create(LocalStorageNamespace*, RefPtr<SecurityOrigin>&&, unsigned quotaInBytes);

This should return Ref.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:57
> +    RefPtr<StorageArea> clone() const;

Ditto.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:120
> +    RefPtr<StorageArea> getOrCreateStorageArea(RefPtr<SecurityOrigin>&& securityOrigin)

Ditto.

> Source/WebKit2/UIProcess/Storage/StorageManager.h:50
> +    static RefPtr<StorageManager> create(const String& localStorageDirectory);

Ditto.
Comment 3 Anders Carlsson 2014-12-16 12:35:59 PST
Committed r177384: <http://trac.webkit.org/changeset/177384>
Comment 4 Chris Dumez 2014-12-16 15:09:53 PST
The patch that landed still uses RefPtr instead of Ref?
Comment 5 Anders Carlsson 2014-12-16 15:25:50 PST
(In reply to comment #4)
> The patch that landed still uses RefPtr instead of Ref?

I fixed it in a couple of followup patches.