Bug 139688

Summary: [iOS] Make it possible to toggle FeatureCounter support at runtime
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: PlatformAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, commit-queue, kling, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 139652, 139794    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-12-16 11:38:40 PST 
Make it possible to toggle FeatureCounter support at runtime using a setting. Also disable FeatureCounter support when a private session is used.

Radar: <rdar://problem/19266254>
Comment 1 Chris Dumez 2014-12-16 11:46:33 PST 
Created attachment 243371 [details]
Patch
Comment 2 mitz 2014-12-16 13:42:21 PST 
Comment on attachment 243371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243371&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:49
> +@property (nonatomic, setter=_setFeatureCounterEnabled:) BOOL _featureCounterEnabled;

This new SPI needs an availability annotation such as WK_AVAILABLE(WK_TBD, WK_TBD)
Comment 3 Chris Dumez 2014-12-16 14:18:55 PST 
Created attachment 243395 [details]
Patch
Comment 4 Chris Dumez 2014-12-16 14:19:28 PST 
(In reply to comment #2)
> Comment on attachment 243371 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243371&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:49
> > +@property (nonatomic, setter=_setFeatureCounterEnabled:) BOOL _featureCounterEnabled;
> 
> This new SPI needs an availability annotation such as WK_AVAILABLE(WK_TBD,
> WK_TBD)

Thanks, done. I used WK_TBA as it seems to be what is used elsewhere.
Comment 5 Chris Dumez 2014-12-17 11:52:39 PST 
Created attachment 243447 [details]
Patch
Comment 6 Andreas Kling 2014-12-17 12:58:43 PST 
Comment on attachment 243447 [details]
Patch

r=me
Comment 7 Chris Dumez 2014-12-17 13:03:04 PST 
Comment on attachment 243447 [details]
Patch

Clearing flags on attachment: 243447

Committed r177455: <http://trac.webkit.org/changeset/177455>
Comment 8 Chris Dumez 2014-12-17 13:03:10 PST 
All reviewed patches have been landed.  Closing bug.