Bug 139676

Summary: Set relayoutChildren to 'true' only if size change happens in Table
Product: WebKit Reporter: Roland Takacs <rtakacs>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, hyatt, kling, kondapallykalyan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ossy: review-, ossy: commit-queue-
Added the missing changelog
none
patch none

Description Roland Takacs 2014-12-16 01:57:52 PST 
This patch passes 'true' value for layoutPositionedObjects() in case of size change.
It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls.
Comment 1 Roland Takacs 2014-12-16 02:00:26 PST 
Created attachment 243354 [details]
patch
Comment 2 Csaba Osztrogonác 2014-12-22 01:17:23 PST 
Comment on attachment 243354 [details]
patch

r- due to missing changelog
Comment 3 Éva Balázsfalvi 2014-12-23 01:09:00 PST 
Created attachment 243668 [details]
Added the missing changelog
Comment 4 Roland Takacs 2014-12-23 01:14:37 PST 
Created attachment 243669 [details]
patch
Comment 5 Darin Adler 2014-12-28 10:51:22 PST 
Comment on attachment 243669 [details]
patch

I guess there’s no simple way to make a test to show the performance improvement from this? Too bad; we really prefer tests for anything like this.
Comment 6 WebKit Commit Bot 2014-12-28 11:32:34 PST 
Comment on attachment 243669 [details]
patch

Clearing flags on attachment: 243669

Committed r177782: <http://trac.webkit.org/changeset/177782>
Comment 7 WebKit Commit Bot 2014-12-28 11:32:39 PST 
All reviewed patches have been landed.  Closing bug.