Bug 139660

Summary: Move 'cursor' CSS property to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-12-15 16:22:57 PST
Move 'cursor' CSS property to the new StyleBuilder.
Attachments
Patch (8.56 KB, patch)
2014-12-15 16:46 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.72 KB, patch)
2014-12-16 16:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-15 16:46:53 PST
Created attachment 243330 [details] Patch
Benjamin Poulain
Comment 2 2014-12-16 15:57:47 PST
Comment on attachment 243330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review > Source/WebCore/css/StyleBuilderCustom.h:1178 > + styleResolver.style()->setCursor(downcast<CSSPrimitiveValue>(item.get())); > + return; If am I not mistaken, this must be the last value. We should assert for that.
Chris Dumez
Comment 3 2014-12-16 16:09:26 PST
Comment on attachment 243330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review >> Source/WebCore/css/StyleBuilderCustom.h:1178 >> + return; > > If am I not mistaken, this must be the last value. We should assert for that. Yes, it should be the last value, I will add the assertion.
Chris Dumez
Comment 4 2014-12-16 16:42:23 PST
Created attachment 243405 [details] Patch
WebKit Commit Bot
Comment 5 2014-12-16 17:17:56 PST
Comment on attachment 243405 [details] Patch Clearing flags on attachment: 243405 Committed r177414: <http://trac.webkit.org/changeset/177414>
WebKit Commit Bot
Comment 6 2014-12-16 17:18:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.