Bug 139660

Summary: Move 'cursor' CSS property to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2014-12-15 16:22:57 PST 
Move 'cursor' CSS property to the new StyleBuilder.
Comment 1 Chris Dumez 2014-12-15 16:46:53 PST 
Created attachment 243330 [details]
Patch
Comment 2 Benjamin Poulain 2014-12-16 15:57:47 PST 
Comment on attachment 243330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review

> Source/WebCore/css/StyleBuilderCustom.h:1178
> +        styleResolver.style()->setCursor(downcast<CSSPrimitiveValue>(item.get()));
> +        return;

If am I not mistaken, this must be the last value. We should assert for that.
Comment 3 Chris Dumez 2014-12-16 16:09:26 PST 
Comment on attachment 243330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review

>> Source/WebCore/css/StyleBuilderCustom.h:1178
>> +        return;
> 
> If am I not mistaken, this must be the last value. We should assert for that.

Yes, it should be the last value, I will add the assertion.
Comment 4 Chris Dumez 2014-12-16 16:42:23 PST 
Created attachment 243405 [details]
Patch
Comment 5 WebKit Commit Bot 2014-12-16 17:17:56 PST 
Comment on attachment 243405 [details]
Patch

Clearing flags on attachment: 243405

Committed r177414: <http://trac.webkit.org/changeset/177414>
Comment 6 WebKit Commit Bot 2014-12-16 17:18:01 PST 
All reviewed patches have been landed.  Closing bug.