Summary: | Move 'cursor' CSS property to the new StyleBuilder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kling, koivisto, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 137910 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2014-12-15 16:22:57 PST
Created attachment 243330 [details]
Patch
Comment on attachment 243330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review > Source/WebCore/css/StyleBuilderCustom.h:1178 > + styleResolver.style()->setCursor(downcast<CSSPrimitiveValue>(item.get())); > + return; If am I not mistaken, this must be the last value. We should assert for that. Comment on attachment 243330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243330&action=review >> Source/WebCore/css/StyleBuilderCustom.h:1178 >> + return; > > If am I not mistaken, this must be the last value. We should assert for that. Yes, it should be the last value, I will add the assertion. Created attachment 243405 [details]
Patch
Comment on attachment 243405 [details] Patch Clearing flags on attachment: 243405 Committed r177414: <http://trac.webkit.org/changeset/177414> All reviewed patches have been landed. Closing bug. |