Bug 139650 – Switching src of <video> with clipping layer results in empty black square.

• Component: New Bugs
• Status: NEW

[Jer Noble]

Switching src of <video> with clipping layer results in empty black square.

[Jer Noble]

Created attachment 243302 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 243302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243302&action=review

> Source/WebCore/ChangeLog:8
> +        Test: compositing/video-clip-change-src.html

Please move to compositing/video/

> LayoutTests/compositing/video-clip-change-src-expected.html:12
> +        video.addEventListener('canplaythrough', endTest);

Seems like this could give a false positive, if both ref and test end before a video frame is actually shown?

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 243302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243302&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Test: compositing/video-clip-change-src.html
> 
> Please move to compositing/video/
> 
> > LayoutTests/compositing/video-clip-change-src-expected.html:12
> > +        video.addEventListener('canplaythrough', endTest);
> 
> Seems like this could give a false positive, if both ref and test end before
> a video frame is actually shown?

It could; should we just do a pixel test here?

[Simon Fraser (smfr)]

> It could; should we just do a pixel test here?

Can you make it so that missing video frames are reliably detected? E.g. <video style="background-color:blue">

[Jer Noble]

Created attachment 243307 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 243307 [details]
Patch for landing

Clearing flags on attachment: 243307

Committed r177324: <http://trac.webkit.org/changeset/177324>