Bug 139650

Summary: Switching src of <video> with clipping layer results in empty black square.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: NEW ---    
Severity: Normal CC: commit-queue, eric.carlson, glenn, philipj, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jer Noble 2014-12-15 11:21:05 PST 
Switching src of <video> with clipping layer results in empty black square.
Comment 1 Jer Noble 2014-12-15 11:24:46 PST 
Created attachment 243302 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-12-15 11:27:14 PST 
Comment on attachment 243302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243302&action=review

> Source/WebCore/ChangeLog:8
> +        Test: compositing/video-clip-change-src.html

Please move to compositing/video/

> LayoutTests/compositing/video-clip-change-src-expected.html:12
> +        video.addEventListener('canplaythrough', endTest);

Seems like this could give a false positive, if both ref and test end before a video frame is actually shown?
Comment 3 Jer Noble 2014-12-15 11:32:08 PST 
(In reply to comment #2)
> Comment on attachment 243302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243302&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Test: compositing/video-clip-change-src.html
> 
> Please move to compositing/video/
> 
> > LayoutTests/compositing/video-clip-change-src-expected.html:12
> > +        video.addEventListener('canplaythrough', endTest);
> 
> Seems like this could give a false positive, if both ref and test end before
> a video frame is actually shown?

It could; should we just do a pixel test here?
Comment 4 Simon Fraser (smfr) 2014-12-15 11:58:34 PST 
> It could; should we just do a pixel test here?

Can you make it so that missing video frames are reliably detected? E.g. <video style="background-color:blue">
Comment 5 Jer Noble 2014-12-15 14:11:58 PST 
Created attachment 243307 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-12-15 17:04:35 PST 
Comment on attachment 243307 [details]
Patch for landing

Clearing flags on attachment: 243307

Committed r177324: <http://trac.webkit.org/changeset/177324>