Bug 139636

Summary: Change HysteresisActivity to use a lambda
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix darin: review+

Description Gavin Barraclough 2014-12-14 21:18:31 PST
The current implementation provides notifications via callbacks to a delegate. Using a delegate with callbacks is limiting a number of ways. The callback names are very ambiguous, the callbacks must either be on a separate object (more boilerplate), or the callback must be public for HysteresisActivity to call them, or friends get involved. Without the boilerplate of extra delegate objects it's hard to scale use of these objects – a single object can't serve as a delegate for multiple HysteresisActivity members.
Comment 1 Gavin Barraclough 2014-12-14 22:02:52 PST
Created attachment 243282 [details]
Fix
Comment 2 Gavin Barraclough 2014-12-15 11:37:04 PST
Transmitting file data ..........
Committed revision 177295.