Bug 139623

Summary: Web Inspector: Empty attribute added to a DOM tree outline element should not add whitespace within the tag
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch none

Brian Burg
Reported 2014-12-13 10:39:26 PST
Steps to reproduce: 1. Click on a DOM element in the DOM tree with no attributes 2. <enter> to start editing 3. <enter> again to commit the edit This adds an empty attribute to the UI, even though the attribute is never added in the backend. If you instead add multiple spaces between steps 2 and 3, the edit is aborted and no extra space is added in the tag (presumably, this is because the backend rejected the change). This is similar to https://bugs.webkit.org/show_bug.cgi?id=111036.
Attachments
Patch (1.52 KB, patch)
2017-03-16 18:54 PDT, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (1.38 KB, patch)
2017-03-18 17:17 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-12-17 11:24:06 PST
<rdar://problem/19281562>
Devin Rousso
Comment 2 2017-03-16 18:54:18 PDT
Created attachment 304738 [details] Patch
Nikita Vasilyev
Comment 3 2017-03-18 16:25:56 PDT
Comment on attachment 304738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304738&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:984 > + if (!newText.trim().length) if (!newText.trim()) An empty string is already a falsy value.
Blaze Burg
Comment 4 2017-03-18 17:07:23 PDT
Comment on attachment 304738 [details] Patch r=me
Devin Rousso
Comment 5 2017-03-18 17:17:09 PDT
Created attachment 304888 [details] Patch
WebKit Commit Bot
Comment 6 2017-03-18 17:58:23 PDT
Comment on attachment 304888 [details] Patch Clearing flags on attachment: 304888 Committed r214141: <http://trac.webkit.org/changeset/214141>
WebKit Commit Bot
Comment 7 2017-03-18 17:58:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.