| Summary: | Implement Data Detectors immediate actions for Legacy WebKit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, conrad_shultz, eric.carlson, glenn, jer.noble, philipj, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-12-13 01:17:46 PST
Created attachment 243253 [details]
Patch
Attachment 243253 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:259: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:260: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:262: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243253&action=review > Source/WebKit/mac/WebView/WebImmediateActionController.h:52 > + BOOL _isShowingTextIndicator; > + RefPtr<WebCore::TextIndicator> _currentDetectedDataTextIndicator; > + BOOL _hasActivatedActionContext; Minor nit: putting both BOOLs at the end of the interface will make this object slightly smaller. > Source/WebKit/mac/WebView/WebImmediateActionController.mm:86 > + _immediateActionRecognizer.enabled = NO; > + _immediateActionRecognizer.enabled = YES; Assuming you do mean to disable and then reenable the recognizer here, it might be worth adding a comment because it looks like it is a copy/paste error. |