Bug 139619 - Implement Data Detectors immediate actions for Legacy WebKit
Summary: Implement Data Detectors immediate actions for Legacy WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-13 01:17 PST by Tim Horton
Modified: 2014-12-15 12:27 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.89 KB, patch)
2014-12-13 01:18 PST, Tim Horton 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-12-13 01:17:46 PST 
Implement Data Detectors immediate actions for Legacy WebKit
Comment 1 Tim Horton 2014-12-13 01:18:50 PST 
Created attachment 243253 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-13 01:20:58 PST 
Attachment 243253 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:259:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:260:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:262:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2014-12-13 07:47:32 PST 
Comment on attachment 243253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243253&action=review

> Source/WebKit/mac/WebView/WebImmediateActionController.h:52
> +    BOOL _isShowingTextIndicator;
> +    RefPtr<WebCore::TextIndicator> _currentDetectedDataTextIndicator;
> +    BOOL _hasActivatedActionContext;

Minor nit: putting both BOOLs at the end of the interface will make this object slightly smaller.

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:86
> +    _immediateActionRecognizer.enabled = NO;
> +    _immediateActionRecognizer.enabled = YES;

Assuming you do mean to disable and then reenable the recognizer here, it might be worth adding a comment because it looks like it is a copy/paste error.
Comment 4 Tim Horton 2014-12-15 11:50:08 PST 
http://trac.webkit.org/changeset/177300
Comment 5 Tim Horton 2014-12-15 12:27:25 PST 
And http://trac.webkit.org/changeset/177304