Bug 139615

Summary:

Make better use of the stack when compiling selectors

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

CSS

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, darin, ddkilzer, kling, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mountainlion-wk2	none
Archive of layout-test-results from ews102 for mac-mountainlion	none
Patch	none
Archive of layout-test-results from ews100 for mac-mountainlion	none
Archive of layout-test-results from ews104 for mac-mountainlion-wk2	none
Patch	none

Benjamin Poulain

Reported 2014-12-12 20:13:53 PST

Make a better use of the stack when compiling selectors

Attachments
Patch (93.62 KB, patch) 2014-12-12 20:34 PST, Benjamin Poulain	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mountainlion-wk2 (521.71 KB, application/zip) 2014-12-12 21:03 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-mountainlion (524.89 KB, application/zip) 2014-12-12 21:18 PST, Build Bot	no flags	Details
Patch (93.62 KB, patch) 2014-12-15 14:59 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mountainlion (513.76 KB, application/zip) 2014-12-15 15:40 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (523.96 KB, application/zip) 2014-12-15 15:44 PST, Build Bot	no flags	Details
Patch (95.28 KB, patch) 2014-12-15 17:32 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-12-12 20:34:27 PST

Created attachment 243243 [details] Patch

Benjamin Poulain

Comment 2 2014-12-12 20:35:11 PST

rdar://problem/19226482

Build Bot

Comment 3 2014-12-12 21:03:08 PST

Comment on attachment 243243 [details] Patch Attachment 243243 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5001637953273856 New failing tests: fast/selectors/not-selector-list-ending-with-never-matching-selectors.html fast/selectors/querySelector-matches.html

Build Bot

Comment 4 2014-12-12 21:03:11 PST

Created attachment 243245 [details] Archive of layout-test-results from ews105 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-12-12 21:18:09 PST

Comment on attachment 243243 [details] Patch Attachment 243243 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5356834969878528 New failing tests: fast/selectors/not-selector-list-ending-with-never-matching-selectors.html

Build Bot

Comment 6 2014-12-12 21:18:12 PST

Created attachment 243246 [details] Archive of layout-test-results from ews102 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Benjamin Poulain

Comment 7 2014-12-15 14:59:35 PST

Created attachment 243312 [details] Patch

Build Bot

Comment 8 2014-12-15 15:40:42 PST

Comment on attachment 243312 [details] Patch Attachment 243312 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4835047983022080 New failing tests: fast/selectors/not-selector-list-ending-with-never-matching-selectors.html

Build Bot

Comment 9 2014-12-15 15:40:45 PST

Created attachment 243321 [details] Archive of layout-test-results from ews100 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2014-12-15 15:44:35 PST

Comment on attachment 243312 [details] Patch Attachment 243312 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6370264178753536 New failing tests: fast/selectors/not-selector-list-ending-with-never-matching-selectors.html fast/selectors/querySelector-matches.html

Build Bot

Comment 11 2014-12-15 15:44:37 PST

Created attachment 243322 [details] Archive of layout-test-results from ews104 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Benjamin Poulain

Comment 12 2014-12-15 17:32:26 PST

Created attachment 243333 [details] Patch

Benjamin Poulain

Comment 13 2014-12-20 16:51:00 PST

bump?

Andreas Kling

Comment 14 2015-01-08 14:14:28 PST

Comment on attachment 243333 [details] Patch r=me

Benjamin Poulain

Comment 15 2015-01-08 17:50:38 PST

Comment on attachment 243333 [details] Patch Clearing flags on attachment: 243333 Committed r178150: <http://trac.webkit.org/changeset/178150>

Benjamin Poulain

Comment 16 2015-01-08 17:50:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.