Bug 139570

Summary: Layer borders on contentsLayers don't correctly toggle with the rest of the borders
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2014-12-11 17:08:52 PST
Layer borders on contentsLayers don't correctly toggle with the rest of the borders
Attachments
Patch (8.70 KB, patch)
2014-12-11 17:12 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-12-11 17:12:47 PST
Created attachment 243165 [details] Patch
Tim Horton
Comment 2 2014-12-11 23:47:18 PST
Comment on attachment 243165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243165&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:702 > + RetainPtr<CGColorSpaceRef> colorSpace = adoptCF(CGColorSpaceCreateDeviceRGB()); > + RetainPtr<CGColorRef> color = adoptCF(CGColorCreate(colorSpace.get(), components)); This maybe should use cachedCGColor (from Color.h)? Simplifies things a bit.
WebKit Commit Bot
Comment 3 2014-12-12 01:15:34 PST
Comment on attachment 243165 [details] Patch Clearing flags on attachment: 243165 Committed r177214: <http://trac.webkit.org/changeset/177214>
WebKit Commit Bot
Comment 4 2014-12-12 01:15:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.