| Summary: | Move the preview popover to WKImmediateActionController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, commit-queue, conrad_shultz, eric.carlson, glenn, jer.noble, philipj, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-12-11 13:42:03 PST
Created attachment 243144 [details]
Patch
Attachment 243144 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:358: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|