WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
139560
Move the preview popover to WKImmediateActionController
https://bugs.webkit.org/show_bug.cgi?id=139560
Summary
Move the preview popover to WKImmediateActionController
Tim Horton
Reported
2014-12-11 13:42:03 PST
Move the preview popover to WKImmediateActionController
Attachments
Patch
(58.61 KB, patch)
2014-12-11 13:42 PST
,
Tim Horton
bdakin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2014-12-11 13:42:46 PST
Created
attachment 243144
[details]
Patch
WebKit Commit Bot
Comment 2
2014-12-11 13:44:16 PST
Attachment 243144
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:358: The parameter name "url" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2014-12-11 14:02:07 PST
http://trac.webkit.org/changeset/177180
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug