Bug 139558

Summary:

Move storage code from WebCore to WebKit

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Anders Carlsson 2014-12-11 12:57:18 PST

Move storage code from WebCore to WebKit

Comment 1 Anders Carlsson 2014-12-11 13:00:58 PST

Created attachment 243140 [details]
Patch

Comment 2 WebKit Commit Bot 2014-12-11 13:03:43 PST

Attachment 243140 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/StorageAreaImpl.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/mac/Storage/WebStorageManager.mm:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:76:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:44:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:93:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:172:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:197:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:373:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageTrackerClient.h:25:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Storage/StorageNamespaceImpl.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageTracker.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageNamespaceImpl.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 19 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2014-12-29 12:55:10 PST

Created attachment 243808 [details]
Patch

Comment 4 WebKit Commit Bot 2014-12-29 12:57:07 PST

Attachment 243808 [details] did not pass style-queue:


ERROR: Source/WebKit/Storage/StorageAreaImpl.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/mac/Storage/WebStorageManager.mm:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:76:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageThread.cpp:92:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:44:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageAreaSync.cpp:91:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebKit/Storage/StorageTrackerClient.h:25:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit/Storage/StorageNamespaceImpl.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageTracker.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.h:45:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/Storage/StorageSyncManager.cpp:66:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 15 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Anders Carlsson 2014-12-29 13:12:29 PST

Committed r177813: <http://trac.webkit.org/changeset/177813>

Comment 6 Csaba Osztrogonác 2014-12-30 01:37:46 PST

Comment on attachment 243808 [details]
Patch

remove r? from landed patch