Summary: | [iOS] Crash in WebKit::WebPageProxy::dispatchViewStateChange() tapping a link from another app while playing a video | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, commit-queue, ddkilzer, eric.carlson, glenn, jeremyj-wk, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2014-12-11 12:31:11 PST
Created attachment 243138 [details]
Patch
Created attachment 243149 [details]
Patch
Attachment 243149 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:964: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:969: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1071: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 6 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 243205 [details]
Patch
Fixed some errors that crept in during rebasing.
Attachment 243205 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:879: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:894: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:918: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:966: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:972: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1074: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 6 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243205 [details] Patch Clearing flags on attachment: 243205 Committed r177375: <http://trac.webkit.org/changeset/177375> All reviewed patches have been landed. Closing bug. |