| Summary: | [Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, fred.wang, glenn, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2014-12-11 10:27:25 PST
Created attachment 243132 [details]
Patch
Attachment 243132 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243132&action=review > Source/WebCore/ChangeLog:8 > + Finish the work began by r173230 and rename mediaElement -> videoElement in WebVideoFullscreenHUDWindowController. Nit: "began"? Created attachment 243134 [details]
Patch for landing
Attachment 243134 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243134 [details] Patch for landing Clearing flags on attachment: 243134 Committed r177179: <http://trac.webkit.org/changeset/177179> Closing this bug since a patch landed for it. |