Bug 139546

Summary: [Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, fred.wang, glenn, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2014-12-11 10:27:25 PST
[Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled.
Attachments
Patch (8.28 KB, patch)
2014-12-11 10:44 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.47 KB, patch)
2014-12-11 11:12 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-12-11 10:28:09 PST
<rdar://problem/19172271>
Jer Noble
Comment 2 2014-12-11 10:44:23 PST
Created attachment 243132 [details] Patch
WebKit Commit Bot
Comment 3 2014-12-11 10:46:24 PST
Attachment 243132 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4 2014-12-11 11:04:49 PST
Comment on attachment 243132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243132&action=review > Source/WebCore/ChangeLog:8 > + Finish the work began by r173230 and rename mediaElement -> videoElement in WebVideoFullscreenHUDWindowController. Nit: "began"?
Jer Noble
Comment 5 2014-12-11 11:12:15 PST
Created attachment 243134 [details] Patch for landing
WebKit Commit Bot
Comment 6 2014-12-11 11:18:12 PST
Attachment 243134 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm:409: The parameter name "videoElement" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2014-12-11 13:57:24 PST
Comment on attachment 243134 [details] Patch for landing Clearing flags on attachment: 243134 Committed r177179: <http://trac.webkit.org/changeset/177179>
Frédéric Wang (:fredw)
Comment 8 2018-05-23 07:51:57 PDT
Closing this bug since a patch landed for it.
Note You need to log in before you can comment on or make changes to this bug.