Bug 139522

Summary:

WK1: Add initial support for immediate actions

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, mitz, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Beth Dakin 2014-12-10 18:44:25 PST

This bug tracks adding initial support for immediate actions to WK1

Comment 1 Beth Dakin 2014-12-10 21:47:33 PST

Created attachment 243099 [details]
Patch

Comment 2 mitz 2014-12-10 21:52:46 PST

Comment on attachment 243099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243099&action=review

> Source/WebKit/mac/WebView/WebImmediateActionController.h:41
> +- (id)initWithWebView:(WebView *)webView;

The return type should be instancetype

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:45
> +- (id)initWithWebView:(WebView *)webView

(and here to match)

Comment 3 Beth Dakin 2014-12-10 22:23:43 PST

Thank you, Dan! http://trac.webkit.org/changeset/177131