Bug 139511

Summary: WK2: Add initial support for immediate actions
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Beth Dakin
Reported 2014-12-10 15:32:22 PST
This bug tracks adding initial support for immediate actions
Attachments
Patch (27.35 KB, patch)
2014-12-10 15:49 PST, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-12-10 15:49:22 PST
Created attachment 243075 [details] Patch
Tim Horton
Comment 2 2014-12-10 15:56:11 PST
Comment on attachment 243075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243075&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3611 > + NSImmediateActionGestureRecognizer *recognizer = [[NSImmediateActionGestureRecognizer alloc] initWithTarget:nil action:NULL]; How does ownership work here? > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:84 > + if ([immediateActionRecognizer view] != _wkView) dot notation > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:96 > + if ([immediateActionRecognizer view] != _wkView) dotto > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:117 > + if ([immediateActionRecognizer view] != _wkView) etc.
Beth Dakin
Comment 3 2014-12-10 16:14:19 PST
Thanks Tim! We talked about the ownership stuff in person. http://trac.webkit.org/changeset/177113
Note You need to log in before you can comment on or make changes to this bug.